Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install all package deps on Noble containers #426

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Install all package deps on Noble containers #426

merged 2 commits into from
Aug 13, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Aug 13, 2024

Proposed changes

Follow-up to #378. Not all package dependencies were brought in by rosdep install. This patch amends that.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@hidmic
Install all package deps on Noble images
7538686 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from serraramiro1 August 13, 2024 02:34
@hidmic hidmic self-assigned this Aug 13, 2024
@hidmic hidmic changed the title Install all package deps on Noble images Install all package deps on Noble dev images Aug 13, 2024
@hidmic hidmic changed the title Install all package deps on Noble dev images Install all package deps on Noble dev containers Aug 13, 2024
@hidmic
Skip slam_toolbox for Rolling
819f8a9 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic changed the title Install all package deps on Noble dev containers Install all package deps on Noble containers Aug 13, 2024
@serraramiro1
Copy link
Contributor

Tested locally, works great! LGTM

@hidmic hidmic merged commit d23d446 into main Aug 13, 2024
16 checks passed
@hidmic hidmic deleted the hidmic/install-deps-on-noble branch August 13, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serraramiro1 serraramiro1 serraramiro1 approved these changes

Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidmic @serraramiro1